Fixed some warnings on MinGW
target when compiling Socket.cpp
.
#1152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following build warnings:
Redefinition of
_WIN32_WINNT
: The macro_WIN32_WINNT
was being redefined inSocket.cpp
. A conditional check has been added to prevent this.Ignored
dllimport
attribute: Warnings related to thedllimport
attribute forinet_pton_func
andinet_ntop_func
were addressed by removing the unnecessaryWINSOCK_API_LINKAGE
.